Skip to content

[skip vbump] upversion 0.12.0 #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
donyunardi wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[skip vbump] upversion 0.12.0 #1449

donyunardi wants to merge 5 commits into from

Conversation

@donyunardi
Copy link
Contributor

@donyunardi donyunardi commented Dec 2, 2025

Fixes #1430

@donyunardi donyunardi added the core label Dec 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025 •
edited
Loading

Unit Tests Summary

  1 files   71 suites   39s ⏱️
734 tests 272 ✅ 462 💤 0 ❌
877 runs  411 ✅ 466 💤 0 ❌

Results for commit fcde0ec.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
examples 💔 $1.69$ $+5.13$ $0$ $-115$ $0$ $0$
tm_t_glm_counts 💔 $0.31$ $+23.97$ $+3$ $-2$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
tm_t_glm_counts 💔 $0.19$ $+11.85$ e2e_tm_t_glm_counts_Module_initializes_in_teal_without_errors_and_produces_table_output.
tm_t_glm_counts 💔 $0.12$ $+12.12$ e2e_tm_t_glm_counts_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit 85860b0

♻️ This comment has been updated with latest results.

osenan
osenan approved these changes Dec 2, 2025
View reviewed changes
Copy link

@osenan osenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok. We should have updated the documentation before. Once we merge the bring_tests branch we have to update the teal.transform dependency to 7.1

@llrs-roche
Copy link
Contributor

llrs-roche commented Dec 3, 2025

To fix the issue on the CI I would suggest to add to the check.yaml that the branch initial_assignment should be used: Replace build-check-install.yaml@main with build-check-install.yaml@initial_assignment. See insightsengineering/r.pkg.template#291 for what I've done.
Once we know that the issue is fixed we can merge that PR and revert changes here.

However, my guess is that testing_depth is "" and skip_if_too_deep() fails to handle that case.
I would fix skip_if_too_deep() function to be robust to such problems (NA, NULL, "") and/or get_testing_depth() to check that the value is numeric (positive).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osenan osenan osenan approved these changes

Assignees

No one assigned

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CRAN Release]: 0.12.0

4 participants

@donyunardi @llrs-roche @osenan